A notification is successful as long as we can send to at least one user #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Dec 13, 2024
James-Pickett
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #1999.
We realized that notifications were being successfully sent to user 501 but not 502, which launcher interpreted as a failure to notify. Therefore, it retried notification. However, the actual end user received the original notification when logged in as user 501 -- and then received repeat notifications every minute thereafter.
This PR corrects that issue, by counting one successfully sent notification as a success.
I also added a log for successfully sending a notification; it would have made tracking down this issue a little easier.