Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from CoInitialize to CoInitializeEx #1973

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

RebeccaMahany
Copy link
Contributor

I noticed some errors in the logs for the test devices with the watchdog enabled:

encountered error checking if watchdog task exists: creating schedule service object: CoInitialize has not been called.

We have already called CoInitialize immediately prior to creating the schedule service object, so this error doesn't make a ton of sense.

When looking through the go-ole issues, I found go-ole/go-ole#124 and go-ole/go-ole#246, both of which seem to indicate that calling CoInitialize instead of CoInitializeEx may be the culprit. I've updated accordingly.

My test device has not emitted this error, but I have regression tested that publishing watchdog logs works; I also tested reinstalling the watchdog task.

This is not a terribly high-priority item -- I think the worst this error could do is prevent us from publishing watchdog logs.

@James-Pickett
Copy link
Contributor

LGTM, I'll wait for @zackattack01 to review

Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me, thank you!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Dec 4, 2024
Merged via the queue into kolide:main with commit a898928 Dec 4, 2024
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/CoInitializeEx branch December 4, 2024 14:28
@RebeccaMahany RebeccaMahany added the bug-fixes Bug Fixes label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fixes Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants