Switch from CoInitialize to CoInitializeEx #1973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some errors in the logs for the test devices with the watchdog enabled:
We have already called
CoInitialize
immediately prior to creating the schedule service object, so this error doesn't make a ton of sense.When looking through the go-ole issues, I found go-ole/go-ole#124 and go-ole/go-ole#246, both of which seem to indicate that calling
CoInitialize
instead ofCoInitializeEx
may be the culprit. I've updated accordingly.My test device has not emitted this error, but I have regression tested that publishing watchdog logs works; I also tested reinstalling the watchdog task.
This is not a terribly high-priority item -- I think the worst this error could do is prevent us from publishing watchdog logs.