Set SystemDrive env var on osquery command #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
approved these changes
Nov 18, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestCreateOsqueryCommandEnvVars(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure this test adds much, but I don't feel that strongly
| // On Windows, we want the `SystemDrive` environment variable to be set to ensure paths can be resolved appropriately. | ||
| // The cmd handles setting `SystemRoot` for us. | ||
| if runtime.GOOS == "windows" { | ||
| if systemDrive, found := os.LookupEnv("SystemDrive"); found { |
There was a problem hiding this comment.
I think we probably need to think hard about the !found case. It might be better to set this to "" than to leave it unset.
There was a problem hiding this comment.
@directionless I tested and confirmed setting SystemDrive= helps, so I made that change in this follow-up PR: #1961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the
SystemDriveenvironment variable to be set on the osquery command to ensure paths can be resolved appropriately.