-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the osquery extension and runner separate rungroups #1596
Merged
RebeccaMahany
merged 7 commits into
kolide:main
from
RebeccaMahany:becca/runner-rungroup
Feb 14, 2024
Merged
Make the osquery extension and runner separate rungroups #1596
RebeccaMahany
merged 7 commits into
kolide:main
from
RebeccaMahany:becca/runner-rungroup
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn knapsack and slogger
James-Pickett
previously approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this is much cleaner!
zackattack01
previously approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! 🔥
RebeccaMahany
dismissed stale reviews from zackattack01 and James-Pickett
via
February 12, 2024 21:00
76988de
zackattack01
approved these changes
Feb 12, 2024
James-Pickett
approved these changes
Feb 12, 2024
Will merge this after we declare v1.5.3 stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1473
Currently, we have an
actorQuerier
rungroup wrapper around both the extension and the runner, which act as a semi-conjoined single rungroup. They don't need to be coupled like this: the extension doesn't need the runner (since we officially disabled the initial runner), and the runner doesn't need the extension (it just needs a couple opts passed in to register the extension correctly when creating the osquery instance). My hope is that decoupling them will make it easier for us to handle the "unenrolled" state and give us better flexibility for how we want to do that. I also think it'll make rewriting our rungroups easier in the future, too.This PR makes the following changes:
osquery
transport method (we don't really use it and haven't for a while)Testing notes
kolide_
tables provided by the extensionosquery_runner
andosquery_extension
as expected