Use TUF metadata to determine version to download when packaging #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/package-channel
branch
from
bb3747e to
e3857c4
Compare
Comment on lines
+138
to
+139
| //go:embed assets/tuf/root.json | ||
| var rootJson []byte |
There was a problem hiding this comment.
I think this is okay. Though we may want some kind of two step, so that we can maintain a newer TUF repo, and not have to fetch/validate everything.
There was a problem hiding this comment.
That'd be nice to have for the ee/tuf code too -- it's on my list (eventually)
|
Looks good. tiny nits |
directionless
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, we will stop using the legacy Notary system, which means we will stop duplicating releases at
<binary>-<channel>.tar.gzand expect clients to find the releases using the TUF metadata for that binary instead. This PR prepares for that by performing those steps when packaging.This duplicates
root.json(also located atee/tuf/assets...) to avoid an import cycle. I didn't think this was a big enough deal to warrant pulling it out and moving it to a new shared location, but if others feel differently I'm happy to update.Relates to #954, #1149