[NixOS support] Run patchelf after autoupdate download #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RebeccaMahany
force-pushed
the
becca/patchelf
branch
from
df8c377 to
7519e94
Compare
RebeccaMahany
force-pushed
the
becca/patchelf
branch
from
7519e94 to
76bc55d
Compare
RebeccaMahany
force-pushed
the
becca/patchelf
branch
from
76bc55d to
3d63d77
Compare
RebeccaMahany
force-pushed
the
becca/patchelf
branch
from
90c9e03 to
2741611
Compare
RebeccaMahany
force-pushed
the
becca/patchelf
branch
from
3fec2e0 to
325366e
Compare
James-Pickett
previously approved these changes
Nov 21, 2023
zackattack01
previously approved these changes
Nov 21, 2023
directionless
requested changes
Nov 22, 2023
RebeccaMahany
dismissed stale reviews from zackattack01 and James-Pickett
via
50b30be
directionless
approved these changes
Nov 22, 2023
Comment on lines
+46
to
+47
| checkedIsNixOS = false | ||
| isNixOS = false |
There was a problem hiding this comment.
Could also use a pointer to a bool. But this is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1200
Relates to #896
Relates to #954
Testing notes
Tested on a NixOS 23.05 VM with a bespoke launcher installation.
Uploaded the binary and used
patchelf --set-interpreterto patch it. Updated the launcher installation so that launcher.flag'slocaldev_pathpointed to the updated binary. Removed all updates from the launcher updates directory, and adjusted the autoupdate interval to something short.Waited for launcher to download a new update. Verified with
patchelf --print-interpreterthat the downloaded binary had been patched appropriately.