Start to include arch in packaging targets + packaging commands #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@directionless it'll fall back to universal for darwin and amd64 for the other two -- no new packaging options or command-line flags at the moment! |
seejdev
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1149
This is a small part of the packaging updates: specifying the architecture we're building for when building packages, to allow us to later specify arm64 when we'd like to build arm64 packages. For macOS, this amounted to moving a hardcoded line out of the dist file, to be set by an option instead. For our FPM packaging, this amounted to passing in the
-aflag, again set by an option. For our Wix build, this is already set: https://github.com/kolide/launcher/blob/main/pkg/packagekit/wix/wix.go#L274