Cross-compile for Linux #1152
Merged
Cross-compile for Linux #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
this looks okay to me, the only thing I noticed was new warning when building
https://github.com/kolide/launcher/actions/runs/4756282010/jobs/8452110679#step:10:13
seejdev
previously approved these changes
Apr 20, 2023
I think that's this: ziglang/zig#13385 Downgrading didn't help, and 0.11.0 isn't available yet, so I guess I'll try setting |
RebeccaMahany
force-pushed
the
becca/arm
branch
2 times, most recently
from
7a981f6 to
ab73f2d
Compare
James-Pickett
previously approved these changes
Apr 20, 2023
RebeccaMahany
force-pushed
the
becca/arm
branch
from
ab73f2d to
fd9712a
Compare
RebeccaMahany
force-pushed
the
becca/arm
branch
from
fd9712a to
da8aec8
Compare
10 tasks
James-Pickett
approved these changes
Apr 20, 2023
James-Pickett
pushed a commit
to James-Pickett/launcher
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #1149
Without setting
-linkmode external, we see errors on build forgrpc.extincludingruntime.gcdata: missing Go type information for global symbol .dynsym: size 72, which indicates per golang/go#52863 that external linking is required.