Skip to content

Commit

Permalink
Version checks don't fail when current not equal to target
Browse files Browse the repository at this point in the history
  • Loading branch information
CJ Barrett committed May 25, 2023
1 parent ef5e2fd commit be442df
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions cmd/launcher/doctor.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,7 @@ func checkupOsquery(updateChannel, tufServerURL, osquerydPath string) (string, e
}

info(fmt.Sprintf("Target version:\t%s", targetVersion))

if targetVersion != currentVersion {
return "", fmt.Errorf("osqueryd is out of date")
}
return "Up to date!", nil
return "Osquery version checks complete", nil
}

func checkupFilesPresent(filepaths []string, importantFiles []*launcherFile) (string, error) {
Expand Down Expand Up @@ -421,11 +417,7 @@ func checkupVersion(updateChannel, tufServerURL string, v version.Info) (string,
}

info(fmt.Sprintf("Target version:\t%s", targetVersion))

if targetVersion != v.Version {
return "", fmt.Errorf("launcher is out of date")
}
return "Up to date!", nil
return "Launcher version checks complete", nil
}

// checkupConfigFile tests that the config file is valid and logs it's contents
Expand Down

0 comments on commit be442df

Please sign in to comment.