Fixes for recent FFmpeg versions #394
Conversation
src/test/java/com/github/kokorin/jaffree/ffmpeg/FFmpegTest.java
Outdated
Show resolved
Hide resolved
jonfryd
force-pushed
the
recent-ffmpeg-version-fixes
branch
from
3100b2a to
b92db0c
Compare
|
@jonfryd it looks like test failures are not related to this PR, right? Probably I have to revisit testing approach in favor of cross ffmpeg version testing instead of testing against latest version. But then cross Java version testing should be dropped. Otherwise it would require too many resources. |
|
I will merge this PR, but not sure when the next release will be. As mentioned, current issues should be fixed first. |
Correct, the test failures are not related. I noticed Mac OS and Windows builds seem to be failing for all active PRs for some reason (didn’t look into it). Yeah, a pragmatic trade off is necessary like you say. It is not practical to test all platforms and many FFmpeg versions on every build. |
OK, sounds good. We’re sticking with FFmpeg 6.0 for now anyway. Take your time. Thanks for your help. Have a good weekend! |
kokorin
force-pushed
the
recent-ffmpeg-version-fixes
branch
from
b92db0c to
96fd294
Compare
|
@jonfryd I have rebased this PR on top of develop branch and changed target branch to develop too. |
KiB) in newer FFmpeg versions.testExceptionIsThrownIfFfmpegExitsWithErrorunit test (again, because the output has recently changed).testFrameCountingWithStreamCopyAndProgressListenerto test frame counting while performing a stream copy. It runs as expected on older FFmpeg versions but fails with recent versions (6.1.x and 7.0.x) due to a bug (which was fixed a week ago on their master branch).