Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KOKKOSFFT_EXPECTS with KOKKOSFFT_THROW_IF #131

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Replace KOKKOSFFT_EXPECTS with KOKKOSFFT_THROW_IF #131

merged 1 commit into from
Sep 11, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

Improves #80

This PR aims at replacing runtime KOKKOSFFT_EXPECTS with KOKKOSFFT_THROW_IF. See discussions in #130 for detail.

@yasahi-hpc yasahi-hpc self-assigned this Sep 11, 2024
tpadioleau
tpadioleau approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have been inverted, seems good to me!

@yasahi-hpc
Copy link
Collaborator Author

All checks have been inverted, seems good to me!

Thank you for your review. I will merge this

@yasahi-hpc yasahi-hpc merged commit 47e3c13 into kokkos:main Sep 11, 2024
20 checks passed
@yasahi-hpc yasahi-hpc deleted the replace-assertion branch September 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@yasahi-hpc yasahi-hpc

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasahi-hpc @tpadioleau