Check View rank and FFT rank consistency #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #80
This PR aims at applying check between View rank and FFT dimension.
Static assertions are applied to Unary and Binary APIs.
In addition, remove
static_assertions
from implementation details since we addedstatic_assertions
to APIs.Following changes are made.
MAX_FFT_DIM
(= 3) inKokkosFFT_common_types.hpp
.static_assertion
to check that FFT dimension is between 1 andMAX_FFT_DIM
(= 3). Some library only supports 1D to 3D FFT.static_assertion
to check thatView::rank() >= FFT dimension
.