Add support to read lines longer than 1023 bytes #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of empty byte sequences in
kk_bytes_cat
and the reading of lines from standard input inkk_os_read_line
.Enhancements to
kk_os_read_line
function:strlen
by allocating string withkk_string_alloc_from_qutf8n
instead ofkk_string_alloc_from_qutf8
.(
kklib/src/os.c
)Improvements to
kk_bytes_cat
function:(
kklib/src/bytes.c
)Considerations
kk_os_read_line
can degrade toO(n^2)
for extremely long lines. However, this seems very unlikely, and I believe this to be a lesser issue than lines being incomplete for lengths>1023
bytes. To solve this we would have to scalebuf
by a factor>1
for each iteration in the loop, which can not be done safely on the stack. Thus it's hard to find a balance between solution complexity, constant overhead and algorithmic complexity. My approach prioritizes solution complexity and constant overhead as it stays true to the previous approach. An approach prioritizing solution complexity and algorithmic complexity can be achieved using thePOSIX
/Dynamic Memory TRgetline(3)
function.