[Week3] 안찬우 : 킹, 랜선 자르기, 크로스워드, 단풍잎이야기 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/3week/acw/단풍잎이야기.kt
Outdated
Comment on lines
28
to
40
| fun countQuests(arr:List<Int>):Int{ | ||
| var count=0 | ||
| loop1@for(i in quests){ | ||
| for(j in i){ | ||
| if(!arr.contains(j)) { | ||
| continue@loop1 | ||
| } | ||
| } | ||
|
|
||
| count++ | ||
| } | ||
| return count | ||
| } |
There was a problem hiding this comment.
이 함수 따로 뺴지 않고 아래와 같이 대체될 수 있을것 같아요
quests.sumOf { quest -> quest.count { q -> arr.contains(q) } }There was a problem hiding this comment.
훨씬 깔끔하고 좋아보입니다. 그런데 만약에 위와 같이 함수로 빼는게 코드량은 늘지만 가독성면에 있어서는 훨씬 좋다면 어떤것을 선택하는게 좋을까요? (물론 위의 함수는 그리 가독성도 좋아보이지는 않습니다만... 만약을 가정하면요 ㅎㅎ...)
늦게 질문드려서 죄송합니다.
There was a problem hiding this comment.
가독성 좋은 쪽을 택하는게 맞습니다
사실 애초에 속도 빠른 코드를 짜기위해서 시스템 코딩을 해야하는 경우엔 Go나 Rust로 짜겠지만 저희는 여러 사람이 함께 작업하는 코드를 만들어가는게 중요하니까요 :)
|
|
||
|
|
||
|
|
||
| println("${(kingX+'A'.toInt()).toChar()}${8-kingY}\n${(stoneX+'A'.toInt()).toChar()}${8-stoneY}") |
There was a problem hiding this comment.
출력에 개행 포함해서 out 연산이 한번인건 좋아요!
이부분도 toString 오버라이딩 해서 king과 stone 출력하는 함수 만들면 king따로 출력연산 구성하고 stone따로 연산 구성할 필요없이 "$king\n$stone" 으로 출력이 끝나겠죠?
[참고 - 현수님 리뷰]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Issue #12
💎 문제 해결
킹: ⭕️
랜선 자르기: ⭕️
크로스워드: ⭕️
단풍잎 이야기: ⭕️
도피: ❌
🔥 특이사항/질문
도피는... dp table을 어떤식으로 renew할지 떠오르지가 않네요... dp는 항상 풀때마다 느끼지만 제가 바보가 되는것만 같습니다 ㅠㅠ