Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_fetch_startup] Add audible warning #233

Merged
merged 2 commits into from
May 20, 2022
Merged

[jsk_fetch_startup] Add audible warning #233

merged 2 commits into from
May 20, 2022

Conversation

iory
Copy link
Collaborator

@iory iory commented May 20, 2022

No description provided.

@iory
Copy link
Collaborator Author

iory commented May 20, 2022

We (@iory @708yamaguchi @tkmtnt7000) confirmed this works.

@708yamaguchi
Copy link
Collaborator

I think audible_warning works very well, thank you so much!

But before mering, we need to remove diagnostics feature from jsk_fetch_startup/warning.py like below.
#223

@708yamaguchi 708yamaguchi mentioned this pull request May 20, 2022
Closed
@iory
Copy link
Collaborator Author

iory commented May 20, 2022

Thank you!

But before mering, we need to remove diagnostics feature from jsk_fetch_startup/warning.py like below.

I cherry-picked the commit.

@708yamaguchi
Copy link
Collaborator

Checked with @tkmtnt7000

@708yamaguchi 708yamaguchi merged commit 21f1acf into knorth55:fetch15 May 20, 2022
@iory iory deleted the fetch15 branch May 20, 2022 14:51
@iory iory restored the fetch15 branch May 20, 2022 14:51
@iory iory deleted the fetch15 branch May 20, 2022 14:52
@iory iory restored the fetch15 branch May 20, 2022 14:52
@708yamaguchi 708yamaguchi mentioned this pull request May 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkmtnt7000 tkmtnt7000 tkmtnt7000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iory @708yamaguchi @tkmtnt7000