Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncate tag text instead of wrapping #324

Merged

Conversation

kylemcd
Copy link
Member

@kylemcd kylemcd commented Nov 19, 2024

Description

Text in the <Tag/> component would wrap two lines if it was too long. This adds a sensible default max-width for the text to wrap to with the ability to set also explicitly set the max-width.

Tasks

KNO-7313

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
telegraph-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:11pm

Copy link

linear bot commented Nov 19, 2024

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 495eb3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@telegraph/tag Patch
@telegraph/combobox Patch
@telegraph/select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

kylemcd commented Nov 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@knock-eng-bot
Copy link
Contributor

Package size differences

No package size differences greater than 20 KB 🚀

All package size differences
  • @telegraph/appearance: 0.00 KB
  • @telegraph/button: 0.00 KB
  • @telegraph/combobox: 0.00 KB
  • @telegraph/compose-refs: 0.00 KB
  • @telegraph/helpers: 0.00 KB
  • @telegraph/icon: 0.00 KB
  • @telegraph/input: 0.00 KB
  • @telegraph/kbd: 0.00 KB
  • @telegraph/layout: 0.00 KB
  • @telegraph/menu: 0.00 KB
  • @telegraph/modal: 0.00 KB
  • @telegraph/nextjs: 0.00 KB
  • @telegraph/popover: 0.00 KB
  • @telegraph/postcss-config: 0.00 KB
  • @telegraph/prettier-config: 0.00 KB
  • @telegraph/radio: 0.00 KB
  • @telegraph/segmented-control: 0.00 KB
  • @telegraph/select: 0.00 KB
  • @telegraph/style-engine: 0.00 KB
  • @telegraph/tag: +1.47 KB
  • @telegraph/tailwind-config: 0.00 KB
  • @telegraph/textarea: 0.00 KB
  • @telegraph/tokens: 0.00 KB
  • @telegraph/tooltip: 0.00 KB
  • @telegraph/typography: 0.00 KB
  • @telegraph/vite-config: 0.00 KB

@kylemcd kylemcd merged commit 3f8386f into main Nov 19, 2024
12 checks passed
@kylemcd kylemcd deleted the kyle-kno-7313-dashboard-workflow-key-wraps-when-too-long branch November 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants