Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App Component #8

Merged
merged 25 commits into from
Jun 3, 2024
Merged

In-App Component #8

merged 25 commits into from
Jun 3, 2024

Conversation

matgar26
Copy link
Contributor

No description provided.

Copy link

@cjbell cjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few initial notes on impl of InAppFeedViewModel (mostly focussed review there)

Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Sources/Components/Feed/InAppFeedViewModel.swift Outdated Show resolved Hide resolved
Copy link

@cjbell cjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯💯💯

@matgar26 matgar26 merged commit 4a62c37 into main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants