Skip to content

Commit

Permalink
Merge pull request #1 from knights-analytics/fix-tests
Browse files Browse the repository at this point in the history
fix unit tests
  • Loading branch information
riccardopinosio authored Feb 12, 2024
2 parents b3e0c29 + a8b2afe commit 470a80f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ permissions:
jobs:
test:
name: Run test suite
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build and run tests
run: make run-tests
release:
name: Release pushed tag
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Create release
env:
Expand All @@ -29,4 +29,4 @@ jobs:
gh release create "$tag" \
--repo="$GITHUB_REPOSITORY" \
--title="${GITHUB_REPOSITORY#*/} ${tag#v}" \
--generate-notes
--generate-notes
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ permissions:
jobs:
test:
name: Run test suite
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build and run tests
run: make run-tests
run: make run-tests
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (

require (
cloud.google.com/go/storage v1.37.0 // indirect
github.com/aws/aws-sdk-go v1.50.14 // indirect
github.com/aws/aws-sdk-go v1.50.15 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/go-errors/errors v1.5.1 // indirect
github.com/jmespath/go-jmespath v0.4.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ cloud.google.com/go/iam v1.1.5 h1:1jTsCu4bcsNsE4iiqNT5SHwrDRCfRmIaaaVFhRveTJI=
cloud.google.com/go/iam v1.1.5/go.mod h1:rB6P/Ic3mykPbFio+vo7403drjlgvoWfYpJhMXEbzv8=
cloud.google.com/go/storage v1.37.0 h1:WI8CsaFO8Q9KjPVtsZ5Cmi0dXV25zMoX0FklT7c3Jm4=
cloud.google.com/go/storage v1.37.0/go.mod h1:i34TiT2IhiNDmcj65PqwCjcoUX7Z5pLzS8DEmoiFq1k=
github.com/aws/aws-sdk-go v1.50.14 h1:m1bxKtd1lJpNnl+Owah0+UPRuS9f3GFvxBPgc8RiodE=
github.com/aws/aws-sdk-go v1.50.14/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/aws/aws-sdk-go v1.50.15 h1:wEMnPfEQQFaoIJwuO18zq/vtG4Ft7NxQ3r9xlEi/8zg=
github.com/aws/aws-sdk-go v1.50.15/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
Expand Down
6 changes: 3 additions & 3 deletions scripts/run-unit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ echo "Downloading the models required for testing from the huggingface hub"

if [[ ! -d "$src_dir/models" ]]; then
mkdir -p $src_dir/models
(cd $src_dir/models && git clone https://huggingface.co/KnightsAnalytics/all-MiniLM-L6-v2 &&\
(cd $src_dir/models && git clone https://huggingface.co/KnightsAnalytics/all-MiniLM-L6-v2 && \
git clone https://huggingface.co/KnightsAnalytics/distilbert-base-uncased-finetuned-sst-2-english && \
git clone git clone https://huggingface.co/KnightsAnalytics/distilbert-NER)
git clone https://huggingface.co/KnightsAnalytics/distilbert-NER)
fi

# build with compose
Expand All @@ -28,4 +28,4 @@ echo "Running tests for commit hash: $commit_hash"

docker compose -f $src_dir/.ci/docker-compose.yaml up && \
docker compose -f $src_dir/.ci/docker-compose.yaml logs --no-color >& $test_folder/logs.txt && \
docker compose -f $src_dir/.ci/docker-compose.yaml rm -fsv
docker compose -f $src_dir/.ci/docker-compose.yaml rm -fsv

0 comments on commit 470a80f

Please sign in to comment.