Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Update dependencies. #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

evankanderson
Copy link
Member

I got a note to upgrade postcss-cli, so I ran npm install --save-dev [email protected].

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2020
@RichieEscarez
Copy link
Contributor

The staging build is failing with:

1:04:35 PM: Building sites … /opt/build/repo/node_modules/fs-extra/lib/mkdirs/make-dir.js:85
1:04:35 PM:       } catch {
1:04:35 PM:               ^
1:04:35 PM: SyntaxError: Unexpected token {
1:04:35 PM:     at createScript (vm.js:80:10)
1:04:35 PM:     at Object.runInThisContext (vm.js:139:10)
1:04:35 PM:     at Module._compile (module.js:617:28)
1:04:35 PM:     at Object.Module._extensions..js (module.js:664:10)
1:04:35 PM:     at Module.load (module.js:566:32)
1:04:35 PM:     at tryModuleLoad (module.js:506:12)
1:04:35 PM:     at Function.Module._load (module.js:498:3)
1:04:35 PM:     at Module.require (module.js:597:17)
1:04:35 PM:     at require (internal/module.js:11:18)
1:04:35 PM:     at Object.<anonymous> (/opt/build/repo/node_modules/fs-extra/lib/mkdirs/index.js:3:44)
1:04:45 PM: Total in 11538 ms
1:04:45 PM: Error: Error building site: POSTCSS: failed to transform "scss/main.css" (text/css): /opt/build/repo/node_modules/fs-extra/lib/mkdirs/make-dir.js:85
1:04:45 PM:       } catch {
1:04:45 PM:               ^
1:04:45 PM: SyntaxError: Unexpected token {
1:04:45 PM:     at createScript (vm.js:80:10)
1:04:45 PM:     at Object.runInThisContext (vm.js:139:10)
1:04:45 PM:     at Module._compile (module.js:617:28)
1:04:45 PM:     at Object.Module._extensions..js (module.js:664:10)
1:04:45 PM:     at Module.load (module.js:566:32)
1:04:45 PM:     at tryModuleLoad (module.js:506:12)
1:04:45 PM:     at Function.Module._load (module.js:498:3)
1:04:45 PM:     at Module.require (module.js:597:17)
1:04:45 PM:     at require (internal/module.js:11:18)
1:04:45 PM:     at Object.<anonymous> (/opt/build/repo/node_modules/fs-extra/lib/mkdirs/index.js:3:44)

@RichieEscarez
Copy link
Contributor

Local builds worked fine. Ill try this in my fork to see what happens.

@RichieEscarez RichieEscarez added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 11, 2020
@RichieEscarez
Copy link
Contributor

The build ran clean in my fork: https://app.netlify.com/sites/knative-v1/deploys/5f5beb9087f4300007a57fbf

Will merge to see what Netlify does.

Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez RichieEscarez removed the request for review from samodell September 11, 2020 21:37
@RichieEscarez
Copy link
Contributor

=( forgot that only a push triggers another build test.

@evankanderson what submodule commit number shows in your client?

Im wondering if we have the same versions of the docsy submodule because I dont see these warnings myself:

2:33:42 PM: ** WARNING **
2:33:42 PM: Using custom ruby version 2.3.6, this will slow down the build.
2:33:42 PM: To ensure fast builds, set the RUBY_VERSION environment variable, or .ruby-version file, to an included ruby version.
2:33:42 PM: Included versions: 2.7.1 2.6.2

I have:

website rescarez$ git submodule
 d6e21af3828f088cd707e06bfeb04fc2346a905a themes/docsy

My fork build log: https://app.netlify.com/sites/knative-v1/deploys/5f5beb9087f4300007a57fbf

@RichieEscarez RichieEscarez removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@evankanderson
Copy link
Member Author

/hold

Still debugging what's going on with PostCSS.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2020
Base automatically changed from master to main March 8, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants