Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of mobile website #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mmejia02
Copy link
Contributor

@mmejia02 mmejia02 commented Mar 7, 2024

Submitting mobile app for review.

Made by Shamayma and Mariana

Changes

  • Typography - main top homescreen text changed colour and size, all font sizes adjusted for mobile
  • Spacing - spacing between buttons on main screen, spacing between components
  • Diagram - Layout, tentative addition of functions

Made by Shamayma and Mariana
@mmejia02 mmejia02 self-assigned this Mar 7, 2024
Copy link

knative-prow bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmejia02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmejia02 Please remove the function part from the PR for now, as it is not on the desktop view yet.

@mmejia02
Copy link
Contributor Author

NEW
Here is the version without functions!

@Cali0707
Copy link
Member

@mmejia02 can you change the file that is in the PR to this updated file? If you need help, please ping me on slack and we can fix the PR together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants