Migrate samples to use configs from build-templates repo #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
imjasonh
changed the title
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Dec 20, 2021
Due to changes done in 68dba4a this test started flaking quite heavily. 1. `getRouteURL` wrongly stopped waiting for the route to actually get an URL. 2. The assertions used to wait for the traffic to actually switch, which it now doesn't necessarily do anymore. We need to wait for the revision state to update first.
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Dec 20, 2021
Due to changes done in 68dba4a this test started flaking quite heavily. 1. `getRouteURL` wrongly stopped waiting for the route to actually get an URL. 2. The assertions used to wait for the traffic to actually switch, which it now doesn't necessarily do anymore. We need to wait for the revision state to update first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all but the FTL build templates from
samples/templates/. These should also be moved tobuild-templatesin the future (knative/build-templates#5).While the
build-templatesrepo is private, this is a bit harder than it has to be. When the build-templates repo goes public, we can tell users to runkubectl apply -f https://raw.githubusercontent.com/elafros/build-templates/master/kaniko/kaniko.yaml.Fixes #854