Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Fix configuration timeout defaulting #15722

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15617

NONE

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@knative-prow knative-prow bot requested review from ReToCode and skonto January 21, 2025 18:40
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (45289f5) to head (2d58803).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15   #15722      +/-   ##
================================================
- Coverage         83.57%   83.56%   -0.01%     
================================================
  Files               219      219              
  Lines             17438    17445       +7     
================================================
+ Hits              14573    14578       +5     
- Misses             2494     2496       +2     
  Partials            371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jan 21, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@dprotaso
Copy link
Member

/approve

Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@knative-prow knative-prow bot merged commit 19ad0d8 into knative:release-1.15 Jan 22, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants