Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in comments #14617

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: typo in comments #14617

merged 1 commit into from
Nov 14, 2023

Conversation

luckymrwang
Copy link
Contributor

@luckymrwang luckymrwang commented Nov 13, 2023

Fixes #

Proposed Changes

Release Note

NONE

Copy link

knative-prow bot commented Nov 13, 2023

Welcome @luckymrwang! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
Copy link

knative-prow bot commented Nov 13, 2023

Hi @luckymrwang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested a review from jsanin-vmw November 13, 2023 15:51
@knative-prow knative-prow bot added the area/API API objects and controllers label Nov 13, 2023
@knative-prow knative-prow bot requested a review from ReToCode November 13, 2023 15:51
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@nak3 nak3 added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2023
@nak3
Copy link
Contributor

nak3 commented Nov 14, 2023

/lgtm
/approve

Copy link

knative-prow bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, luckymrwang, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (946643c) 86.00% compared to head (4bb3986) 86.04%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14617      +/-   ##
==========================================
+ Coverage   86.00%   86.04%   +0.03%     
==========================================
  Files         197      197              
  Lines       14916    14922       +6     
==========================================
+ Hits        12828    12839      +11     
+ Misses       1778     1774       -4     
+ Partials      310      309       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

/retest

1 similar comment
@ReToCode
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit 936ecbd into knative:main Nov 14, 2023
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants