Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST-ONLY] testing cluster-local-domain-tls in Serving #14577

Closed

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Nov 1, 2023

/hold

WIP

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/API API objects and controllers labels Nov 1, 2023
Copy link

knative-prow bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ReToCode
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2023
@ReToCode ReToCode force-pushed the cluster-local-tls-internal-issuer branch 3 times, most recently from 251c568 to 84859b7 Compare November 1, 2023 12:22
@ReToCode ReToCode force-pushed the cluster-local-tls-internal-issuer branch from 84859b7 to 4a14d9e Compare November 2, 2023 07:32
Copy link

knative-prow bot commented Nov 2, 2023

@ReToCode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main 4a14d9e link true /test unit-tests
istio-latest-no-mesh_serving_main 4a14d9e link true /test istio-latest-no-mesh
kourier-stable_serving_main 4a14d9e link true /test kourier-stable

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode ReToCode closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants