Skip to content

Commit

Permalink
changed activationrequired condition while reconciling the revision s…
Browse files Browse the repository at this point in the history
…o the deployment status is propagated when there is something wrong (like low resources request and limits), since it was just beign propagated when the revision status was nil and the deployment existed
  • Loading branch information
gabo1208 committed Sep 27, 2023
1 parent 28effd9 commit dfe2bd7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/reconciler/revision/reconcile_resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (c *Reconciler) reconcileDeployment(ctx context.Context, rev *v1.Revision)
// The autoscaler mutates the deployment pretty often, which would cause us
// to flip back and forth between Ready and Unknown every time we scale up
// or down.
if !rev.Status.IsActivationRequired() {
if rev.Status.IsActivationRequired() {
rev.Status.PropagateDeploymentStatus(&deployment.Status)
}
}
Expand Down

0 comments on commit dfe2bd7

Please sign in to comment.