Skip to content

Commit

Permalink
with some istio cases this could fail with progress deadline exceeded…
Browse files Browse the repository at this point in the history
… error so adding that case too
  • Loading branch information
gabo1208 committed Nov 7, 2023
1 parent 2b999c8 commit b02331f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test/e2e/resource_quota_error_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func TestResourceQuotaError(t *testing.T) {
clients := test.Setup(t, test.Options{Namespace: "rq-test"})
const (
errorReason = "RevisionFailed"
progressDeadlineReason = "ProgressDeadlineExceeded"
waitReason = "ContainerCreating"
errorMsgQuota = "forbidden: exceeded quota"
revisionReason = "RevisionFailed"
Expand Down Expand Up @@ -83,6 +84,7 @@ func TestResourceQuotaError(t *testing.T) {
if cond.Reason == errorReason && cond.IsFalse() {
return true, nil
}
if cond.Reason ==

Check failure on line 87 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / style / Golang / Lint

[trailing whitespace] reported by reviewdog 🐶 if cond.Reason == Raw Output: test/e2e/resource_quota_error_test.go:87: if cond.Reason ==
t.Logf("Reason: %s ; Message: %s ; Status: %s", cond.Reason, cond.Message, cond.Status)
return true, fmt.Errorf("the service %s was not marked with expected error condition (Reason=%q, Message=%q, Status=%q), but with (Reason=%q, Message=%q, Status=%q)",

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / style / Golang / Auto-format and Check

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / build / Build

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, kourier, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, kourier, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, kourier, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, kourier, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, kourier-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, istio, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, contour, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.27.x, istio-tls, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.28.x, istio-ambient, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, kourier, e2e)

expected operand, found 'return'

Check failure on line 89 in test/e2e/resource_quota_error_test.go

View workflow job for this annotation

GitHub Actions / test (v1.26.x, kourier, e2e)

expected operand, found 'return'
names.Config, errorReason, "", "False", cond.Reason, cond.Message, cond.Status)
Expand Down Expand Up @@ -112,6 +114,10 @@ func TestResourceQuotaError(t *testing.T) {
if strings.Contains(cond.Message, errorMsgQuota) && cond.IsFalse() {
return true, nil
}
// Can fail with either a progress deadline exceeded error
if cond.Reason == progressDeadlineReason {
return true, nil
}
// wait for the container creation
if cond.Reason == waitReason {
return false, nil
Expand Down

0 comments on commit b02331f

Please sign in to comment.