Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklists + restructure instructions #132

Merged
merged 14 commits into from
Jun 14, 2022

Conversation

carlisia
Copy link
Member

@carlisia carlisia commented May 28, 2022

Closes #111.

What: This PR's big goal is to decouple these concepts:

  • procedure documentation
  • listing of things to be done
  • sequencing of things to be done

How:

  • adds 1 GH issue templates with a list of todos for the release

  • adds a PROCEDURE.md file that:

    • documents relevant operations related to a release
    • includes a short version of a ToC at the top specifying the specific order in which to perform operations
    • adds an Exceptions section (for operations that have exceptions) so when going thru the instructions in order, it is clear what is to be skipped
  • adds a PHASES.md TIMELINE.md file that:

    • functions as an entry point for where, when and how to get started with the release work
    • groups repos and operations for a release into separate checkpoints in the release timeline, much in the way that was in the original doc
    • includes links to only relevant sections in the (Procedure) documentation related to a particular checkpoiint
  • removes the INSTRUCTIONS.md file, since the info in there has been split into the above two new files; didn't reuse the name "instructions" because both new files contain instructions, so named them more precisely to reflect the content of each.

There were a lot of minor edits to the documentation.

Minor changes worth noting:

  • spruced up the README.me.
    • removed the table of repos, since they are all listed (per phase) in the PHASES.md file. If it is useful to have that unified table of repos up on the front page, I can put it back. ❓
  • changed the PR used as reference to add/remove leads (in the PROCEDURES.md file) since the existing one being used didn't update the OWNERS_ALIASES file
  • I don't know if the value for the assignees field in the templates will work. Using knative/knative-release-leads failed the regex validation, so I used only knative-release-leads to test. Either it will work, or be ignored.

Thanks to @nader-ziada and @psschwei for the prior improvements!


updated on 6/8

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 28, 2022
@psschwei
Copy link
Contributor

@carlisia is this still WIP? (looking forward to giving this a go on the next release cycle!)

@carlisia
Copy link
Member Author

Hey @psschwei yes, still wip, will update shortly!

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2022
@carlisia carlisia force-pushed the release-template branch from ca34f65 to e77de89 Compare June 3, 2022 15:17
carlisia added 2 commits June 3, 2022 08:28
wip:
- extracted all todos into GH template checklists
- further restructured the instructions to decouple instructions
  (procedures) from references (the lists of repos)

todo:
- add a GH template checklist for the post-release tasks
- edit the sections under release procedures
- edit the existing checklists to point to the new subsections in the
  INSTRUCTIONS.md file, as well as improve the descriptions.
@carlisia carlisia force-pushed the release-template branch from e77de89 to e9bab4f Compare June 3, 2022 15:28
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2022
@carlisia carlisia marked this pull request as ready for review June 3, 2022 18:44
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2022
@carlisia
Copy link
Member Author

carlisia commented Jun 3, 2022

Pinging ppl who might be interested in reviewing this change. Please don't all feel required to review 🤓

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is great and will make the release process much easier going forward!

One general question: what do you think about adding direct links to the procedures from the task items? For example, when starting on the "updating the releasability defaults" task in template 2, I think it'd be nice to be able to click straight to that section rather than going through the phases doc to get there.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but lgtm

.github/ISSUE_TEMPLATE/9-post-release.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/7-t-minus-0-third-batch.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/8-t-minus-0-last-batch.yaml Outdated Show resolved Hide resolved
PHASES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
@carlisia
Copy link
Member Author

carlisia commented Jun 3, 2022

Overall, I think this is great and will make the release process much easier going forward!

One general question: what do you think about adding direct links to the procedures from the task items? For example, when starting on the "updating the releasability defaults" task in template 2, I think it'd be nice to be able to click straight to that section rather than going through the phases doc to get there.

Hm... that is how I started doing it. I decided to go this way to avoid having a bunch of links in the checklist. Having only 1 entry point to the documentation for each checklist and having it match to the corresponding phase made it feel like there is some uniform convention. And this avoids the following nightmare scenario: someone changes anything to do with the sections of that Procedures file, and now a linke broken or not as relevant. It could be hard to remember, and a pain to also have to, change it in the checklist.

@dprotaso
Copy link
Member

dprotaso commented Jun 6, 2022

adds 9 GH issue templates

My preference is to consolidate the templates into a single one.

Some advantages in my mind:

  1. There would be a stable link for the entire release process - so anyone could visit that link and see the overall progress that's been made
  2. More ergonomic - single issue vs. opening/closing 9 issues.

@psschwei
Copy link
Contributor

psschwei commented Jun 6, 2022

scenario: someone changes anything to do with the sections of that Procedures file, and now a linke broken or not as relevant. It could be hard to remember, and a pain to also have to, change it in the checklist.

That's funny, my initial worry was the opposite, where someone changes something in the Procedures but doesn't update the issue and/or the Phases doc. If it's six in one and half dozen in the other, may as well go with the bird in hand (I thought about trying to work one more bird allusion in there, but couldn't quite bring myself to cross that road...)

My preference is to consolidate the templates into a single one.

I think I agree with Dave on this, though I don't think Github wanted me to tell you about it:

image

@carlisia carlisia requested a review from psschwei June 8, 2022 19:29
@carlisia
Copy link
Member Author

carlisia commented Jun 8, 2022

This is ready for another review:

  • addressed the concerns
  • made changes to the doc, mainly scratching the concept of "phases" and changing that to "timeline checkpoints"
  • converged all checklists into 1 checklist

I am resisting adding a bunch of links to documentation in the checklist (each pointing to corresponding sections of the PROCEDURES doc. If anything, we need those links in the TIMELINE anyway, so that would cause duplication. My suggestion: use this version for the next one or two releases, and if the leads report it'd be convenient to have those links in the checklist, then they can be added.

@carlisia
Copy link
Member Author

carlisia commented Jun 8, 2022

Note: there's no instruction for how to put together a blog post for the release. I added an issue for that to be added later: Add instructions for how to put together a blog post for a new release · Issue #137 · knative/release.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but otherwise LGTM

PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Outdated Show resolved Hide resolved
PROCEDURES.md Show resolved Hide resolved
@carlisia
Copy link
Member Author

Thanks for the very helpful review @psschwei! I believe I hit them all.

Ready for another round.

@carlisia carlisia requested a review from psschwei June 10, 2022 22:04
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for others to comment

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2022
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2022
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, evankanderson, gabo1208, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,psschwei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cbcfce9 into knative:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GH issue template with a checklist for releases
6 participants