-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checklists + restructure instructions #132
Conversation
@carlisia is this still WIP? (looking forward to giving this a go on the next release cycle!) |
Hey @psschwei yes, still wip, will update shortly! |
ca34f65
to
e77de89
Compare
wip: - extracted all todos into GH template checklists - further restructured the instructions to decouple instructions (procedures) from references (the lists of repos) todo: - add a GH template checklist for the post-release tasks - edit the sections under release procedures - edit the existing checklists to point to the new subsections in the INSTRUCTIONS.md file, as well as improve the descriptions.
e77de89
to
e9bab4f
Compare
Pinging ppl who might be interested in reviewing this change. Please don't all feel required to review 🤓
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is great and will make the release process much easier going forward!
One general question: what do you think about adding direct links to the procedures from the task items? For example, when starting on the "updating the releasability defaults" task in template 2, I think it'd be nice to be able to click straight to that section rather than going through the phases doc to get there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but lgtm
Hm... that is how I started doing it. I decided to go this way to avoid having a bunch of links in the checklist. Having only 1 entry point to the documentation for each checklist and having it match to the corresponding phase made it feel like there is some uniform convention. And this avoids the following nightmare scenario: someone changes anything to do with the sections of that Procedures file, and now a linke broken or not as relevant. It could be hard to remember, and a pain to also have to, change it in the checklist. |
My preference is to consolidate the templates into a single one. Some advantages in my mind:
|
That's funny, my initial worry was the opposite, where someone changes something in the Procedures but doesn't update the issue and/or the Phases doc. If it's six in one and half dozen in the other, may as well go with the bird in hand (I thought about trying to work one more bird allusion in there, but couldn't quite bring myself to cross that road...)
I think I agree with Dave on this, though I don't think Github wanted me to tell you about it: |
This is ready for another review:
I am resisting adding a bunch of links to documentation in the checklist (each pointing to corresponding sections of the |
Note: there's no instruction for how to put together a blog post for the release. I added an issue for that to be added later: Add instructions for how to put together a blog post for a new release · Issue #137 · knative/release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits, but otherwise LGTM
Thanks for the very helpful review @psschwei! I believe I hit them all. Ready for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
for others to comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlisia, evankanderson, gabo1208, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #111.
What: This PR's big goal is to decouple these concepts:
How:
adds 1 GH issue templates with a list of todos for the release
adds a
PROCEDURE.md
file that:adds a
PHASES.md
TIMELINE.md
file that:removes the
INSTRUCTIONS.md
file, since the info in there has been split into the above two new files; didn't reuse the name "instructions" because both new files contain instructions, so named them more precisely to reflect the content of each.There were a lot of minor edits to the documentation.
Minor changes worth noting:
README.me
.PHASES.md
file. If it is useful to have that unified table of repos up on the front page, I can put it back. ❓PROCEDURES.md
file) since the existing one being used didn't update theOWNERS_ALIASES
fileassignees
field in the templates will work. Usingknative/knative-release-leads
failed the regex validation, so I used onlyknative-release-leads
to test. Either it will work, or be ignored.Thanks to @nader-ziada and @psschwei for the prior improvements!
updated on 6/8