Add more env vars for pingsource adapter env var preservation (#1538)

Co-authored-by: Ali Ok <[email protected]>
knative · Aug 17, 2023 · 1d1da62 · 1d1da62
1 parent b17259d
commit 1d1da62
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/pkg/reconciler/knativeeventing/common/replicasenvvarstransform.go b/pkg/reconciler/knativeeventing/common/replicasenvvarstransform.go
@@ -30,7 +30,7 @@ import (
 
 var (
 	envVarNames = sets.NewString(system.NamespaceEnvKey, "K_METRICS_CONFIG", "K_LOGGING_CONFIG",
-		"K_LEADER_ELECTION_CONFIG", "K_NO_SHUTDOWN_AFTER", "K_SINK_TIMEOUT")
+		"K_LEADER_ELECTION_CONFIG", "K_NO_SHUTDOWN_AFTER", "K_SINK_TIMEOUT", "K_TRACING_CONFIG", "NAMESPACE")
 )
 
 type unstructuredGetter interface {

diff --git a/pkg/reconciler/knativeeventing/common/replicasenvvarstransform_test.go b/pkg/reconciler/knativeeventing/common/replicasenvvarstransform_test.go
@@ -63,6 +63,10 @@ func TestPingsourceMTAadapterTransform(t *testing.T) {
                   value: ''
                 - name: K_LOGGING_CONFIG_1
                   value: 'overwrite'
+                - name: K_TRACING_CONFIG
+                  value: 'to be overwritten'
+                - name: NAMESPACE
+                  value: 'to be overwritten'
   existing:
     apiVersion: apps/v1
     kind: Deployment
@@ -88,6 +92,10 @@ func TestPingsourceMTAadapterTransform(t *testing.T) {
                   value: 'old'
                 - name: K_LOGGING_CONFIG_1
                   value: 'old'
+                - name: K_TRACING_CONFIG
+                  value: 'old'
+                - name: NAMESPACE
+                  value: 'old'
   expected:
     apiVersion: apps/v1
     kind: Deployment
@@ -111,6 +119,10 @@ func TestPingsourceMTAadapterTransform(t *testing.T) {
                   value: 'old'
                 - name: K_LOGGING_CONFIG
                   value: 'old'
+                - name: K_TRACING_CONFIG
+                  value: 'old'
+                - name: NAMESPACE
+                  value: 'old'
                 - name: K_LOGGING_CONFIG_1
                   value: 'overwrite'
 - name: "existing pingsource-mt-adapter has less containers"