Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace knative.dev/client references to knative.dev/client-pkg #1671

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Apr 9, 2023

Changes

  • 🧹 Replaced the occurrences of knative.dev/client with knative.dev/client-pkg

/kind cleanup

Part of knative/client#1591

Release Note


Docs


@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2023
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (18d8398) 62.67% compared to head (aacb9bf) 62.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
+ Coverage   62.67%   62.78%   +0.11%     
==========================================
  Files          93       93              
  Lines       11964    11964              
==========================================
+ Hits         7498     7512      +14     
+ Misses       3783     3770      -13     
+ Partials      683      682       -1     
Flag Coverage Δ
e2e-test 38.84% <ø> (ø)
e2e-test-oncluster ?
e2e-test-oncluster-runtime 29.55% <ø> (?)
e2e-test-runtime-go 28.14% <ø> (?)
e2e-test-runtime-node 29.38% <ø> (?)
e2e-test-runtime-python 29.38% <ø> (?)
e2e-test-runtime-quarkus 29.51% <ø> (?)
e2e-test-runtime-springboot 28.40% <ø> (?)
e2e-test-runtime-typescript 29.51% <ø> (?)
integration-tests 49.35% <ø> (ø)
unit-tests-macos-latest 48.16% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.12% <ø> (+0.02%) ⬆️
unit-tests-windows-latest 48.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/deploy.go 74.78% <ø> (-0.66%) ⬇️
cmd/root.go 76.37% <ø> (ø)
cmd/run.go 71.06% <ø> (ø)
pkg/knative/client.go 53.84% <ø> (ø)
pkg/knative/deployer.go 68.54% <ø> (ø)
pkg/knative/describer.go 69.11% <ø> (ø)
pkg/knative/lister.go 64.91% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance
Copy link
Member

lance commented Apr 10, 2023

@vyasgun thanks for this - and welcome back! :)

It looks like the verify codegen action failed, which is common if you are using a newer (M1) mac. You can resolve this by running the following command from the root directory in your branch and updating the PR.

docker run -it --rm -v$(pwd):/src/:Z golang sh -c 'cd /src && ./hack/update-codegen.sh'

@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 10, 2023

Thanks a lot @lance - happy to be back! The suggestion worked and the action is passing now :)

@lance
Copy link
Member

lance commented Apr 10, 2023

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

@knative-prow
Copy link

knative-prow bot commented Apr 10, 2023

@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml

In response to this:

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Apr 10, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8f2f290 into knative:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants