-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace knative.dev/client references to knative.dev/client-pkg #1671
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
+ Coverage 62.67% 62.78% +0.11%
==========================================
Files 93 93
Lines 11964 11964
==========================================
+ Hits 7498 7512 +14
+ Misses 3783 3770 -13
+ Partials 683 682 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@vyasgun thanks for this - and welcome back! :) It looks like the verify codegen action failed, which is common if you are using a newer (M1) mac. You can resolve this by running the following command from the root directory in your branch and updating the PR.
|
Thanks a lot @lance - happy to be back! The suggestion worked and the action is passing now :) |
/override "style / suggester / shell" |
@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup
Part of knative/client#1591
Release Note
Docs