Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventing-gitlab repo to update-nightlies workflow #402

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Add eventing-gitlab repo to update-nightlies workflow #402

merged 6 commits into from
Sep 9, 2024

Conversation

harsh098
Copy link
Contributor

Changes

assignee: @harsh098
Add eventing-gitlab repo to update-nightlies workflow.

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 28, 2024

@harsh098: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

assignee: @harsh098
Add eventing-gitlab repo to update-nightlies workflow.

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from cardil and upodroid August 28, 2024 19:51
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 28, 2024

Welcome @harsh098! It looks like this is your first PR to knative-extensions/knobots 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@harsh098 harsh098 mentioned this pull request Aug 28, 2024
Open
creydr
creydr suggested changes Aug 29, 2024
View reviewed changes
.github/workflows/update-nightlies.yaml Outdated Show resolved Hide resolved
.github/workflows/update-nightlies.yaml Outdated Show resolved Hide resolved
.github/workflows/update-nightlies.yaml Outdated Show resolved Hide resolved
.github/workflows/update-nightlies.yaml Outdated Show resolved Hide resolved
.github/workflows/update-nightlies.yaml Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2024
@harsh098
Copy link
Contributor Author

Requested Changes had been made @creydr
Pls review

@harsh098
Copy link
Contributor Author

harsh098 commented Sep 7, 2024

Any updates @creydr @cardil ?

creydr
creydr approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, harsh098

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@creydr
Copy link
Contributor

creydr commented Sep 9, 2024

Sorry for the delay @harsh098. Somehow missed this. Looks good so far

@knative-prow knative-prow bot merged commit 36b11a6 into knative-extensions:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsh098 @creydr