Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced knative/client references with client-pkg #254

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Replaced knative/client references with client-pkg #254

merged 3 commits into from
Dec 2, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Oct 31, 2022 •
edited
Loading

Description

Changes

  • Updated client references to client-pkg in go files

Reference

Part of changes for knative/client#1591

/cc @dsimansk

knative-prow[bot]
knative-prow bot reviewed Oct 31, 2022
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Changes

  • Updated client references to client-pkg in go files

Reference

Part of changes for knative/client#1591

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 31, 2022
@vyasgun
Copy link
Contributor Author

vyasgun commented Oct 31, 2022

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
@vyasgun
Copy link
Contributor Author

vyasgun commented Oct 31, 2022

The build test was failing because of an indirect dependency github.com/cloudevents/sdk-go/sql/v2. I have added a temporary fix in go.mod for now.

@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited
Loading

Codecov Report

Merging #254 (ce3517f) into main (040bbc0) will not change coverage.
The diff coverage is n/a.

❗ Current head ce3517f differs from pull request most recent head e892f59. Consider uploading reports for the commit e892f59 to get more accurate results

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   48.45%   48.45%           
=======================================
  Files           7        7           
  Lines         518      518           
=======================================
  Hits          251      251           
  Misses        252      252           
  Partials       15       15
Impacted Files Coverage Δ
pkg/client/client.go 55.17% <ø> (ø)
pkg/factories/rune_factory.go 21.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vyasgun
Copy link
Contributor Author

vyasgun commented Oct 31, 2022

/retest

@vyasgun
Copy link
Contributor Author

vyasgun commented Nov 28, 2022

Current tests are failing due to client-pkg's dependency on github.com/maximilien/kn-source-pkg which has been fixed in the knative.dev/client-pkg PR knative/client-pkg#74. Once it is merged, the issues should resolve.

@vyasgun
Copy link
Contributor Author

vyasgun commented Dec 1, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@dsimansk
Copy link
Contributor

dsimansk commented Dec 2, 2022

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@knative-prow knative-prow bot merged commit dca595c into knative-extensions:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasgun @dsimansk