Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace knative.dev/client references with knative.dev/client-pkg #255

Closed
wants to merge 1 commit into from

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jan 23, 2023

Changes

  • Replaced the occurrences of knative.dev/client with knative.dev/client-pkg
  • A few dependencies upgraded during the build which caused a field change in eventingv1.BrokerStatus. I updated the code accordingly in addressresolver_cases.go.

/kind cleanup

Part of knative/client#1591

Release Note


Docs


@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #255 (7990dd5) into main (5b799ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          35       35           
  Lines        1128     1128           
=======================================
  Hits          769      769           
  Misses        299      299           
  Partials       60       60           
Impacted Files Coverage Δ
pkg/cli/target.go 48.57% <ø> (ø)
pkg/plugin/plugin.go 100.00% <ø> (ø)
pkg/plugin/testing.go 94.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2023
@knative-prow knative-prow bot closed this in #260 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants