EPUBMaker: verify_target_imagesが有効なときに、coverimageを暗黙に取り込む #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmuto
changed the title
|
Windows固有の挙動に釈然としていないのですが、テンポラリフォルダ削除時のEACCES, ENOTEMPTYを握り潰すようにしています。 |
|
細かいところで気になるところはあるんですが、このPRとはあんまり関係なさそうなのでこれはこれで取り込んでいいんではないかと（例えば |
はい、そのあたりは全体ガッツリやっちゃってください! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1918 で言及した、verify_target_imagesが有効なときにcoverimageの画像ファイルも暗黙に取り込むものです。
imagedirで設定されたフォルダ(通常はimages)直下にあるcoverimageの画像ファイルを探す決めうちとしています。