Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini_magick: use SSIM instead of AE for compare #1921

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

takahashim
Copy link
Collaborator

#1917 の対応で、ImageMagickのcopmareのmetricとしてSSIMを使うようにしてみます。

https://qiita.com/yoya/items/510043d836c9f2f0fe2f

しきい値は0.9で、それ以上なら一致・それ未満なら不一致ということにしています。
なお-fuzzはあってもなくても変わらなかったので落としています。

@takahashim
Copy link
Collaborator Author

えー、SSIMはImageMagick 7じゃないと使えないのか! これはどうしたものか…。

@takahashim takahashim force-pushed the fix-mini-magick-compare branch 5 times, most recently from 7273f58 to ccf42f6 Compare August 16, 2024 07:04
@takahashim
Copy link
Collaborator Author

https://imagemagick.org/script/download.php で配布してるAppImage版のimagemagick v7をvendor/imagemagick以下に入れて、GitHub Actionsで使うようにしてみました。
gemには含めないようにしています。

Copy link
Owner

@kmuto kmuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、ありがとうございます!

手元では PATH=~/review/vendor/imagemagick:$PATH rake test で動作確認できました

@kmuto
Copy link
Owner

kmuto commented Aug 19, 2024

マージしておきますね

@kmuto kmuto merged commit e0a83db into master Aug 19, 2024
17 checks passed
@kmuto kmuto deleted the fix-mini-magick-compare branch August 19, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants