Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased python functionality #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kiyo-masui
Copy link

No description provided.

This includes an API change: `assembler.python_processor` which was a
`processor` object has been replaced by `assembler.python_processors`
which is a list.

Python processors are run sequencially, not on separate threads.
@kiyo-masui
Copy link
Author

@kmsmith137 There are two sketchy things in this PR that you might be able to comment on. The first is a const_cast of the chunks packed data so I can wrap that data in an array.

The second is that I don't fully understand how the memory management of the chunk's byte data works. I'm worried that the memory might be deallocated before the numpy array goes out of scope. This shouldn't be an issue in the current code since the python side is strictly sequential, however it might not be future proof.

Both concerns are described in more detail in comments in the source.

@kiyo-masui
Copy link
Author

@kmsmith137 bump

Some ARO folks have been looking at this and getting confused about versions, so I think we should converge on this ASAP.

@kiyo-masui
Copy link
Author

Also @misanthropealoupe, this is what I was referring to in my email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant