Fix user_info method for Add to Slack #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When going through the standard Add to Slack authentication procedure, the user_identity["id"] is empty because you can't mix the identity.basic scopes with other team wide scopes. Luckily, Slack returns the current logged in users id in the access_token params object, so we should use that if user_identity["id"] is nil
|
Any reason this never got merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going through an initial Add to Slack flow, you can't mix the
identity.basicscope with other team-wide scopes being requested (liketeam:readorusers:read). However, Slack does give us the currently signed in user_id inside ouraccess_token.paramsobject. So, if for whatever reason our user_identity['id'] is nil, we should grab the user_id fromaccess_token.paramsso that we get the current users information instead of an error.