Skip to content

Commit

Permalink
Update g16calc for new pymatgen version
Browse files Browse the repository at this point in the history
  • Loading branch information
kmlefran committed Jan 26, 2024
1 parent 55553f4 commit 120d7b9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ jobs:

- name: Setup `g16wfx`
run: verdi code create core.code.installed -n --config .github/config/code-gwfx.yaml --filepath-executable /Users/chemlab/Desktop/g16/g16

- name: Setup groups
run: verdi group create inp_frag

docs:
runs-on: ubuntu-latest
timeout-minutes: 15
Expand Down
2 changes: 1 addition & 1 deletion aiida_aimall/calculations.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,4 +356,4 @@ def _render_input_string_from_params(cls, parameters, structure_string):
parameters.setdefault("spin_multiplicity", parameters.pop("multiplicity", None))
parameters["title"] = "input generated by the aiida-gaussian plugin"
gaussian_input = GaussianInput(structure_string, **parameters)
return gaussian_input.to_string(cart_coords=True)
return gaussian_input.to_str(cart_coords=True)
9 changes: 3 additions & 6 deletions tests/controllers/test_g16fragcontroller.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Tests for aiida_aimall.controllers"""
import pytest
from aiida.common.exceptions import NotExistent
from aiida.orm import Group, Str
from aiida.orm import Str

# pylint:disable=no-name-in-module
from aiida_aimall.controllers import G16FragController
Expand All @@ -14,7 +14,7 @@ def test_unstored_parentgrouplabel_returns_error():
"""Test that error returns when groups are not defined"""
with pytest.raises(NotExistent) as excinfo:
G16FragController(
parent_group_label="inp_frag",
parent_group_label="empty",
group_label="opt_workchain",
max_concurrent=1,
code_label="test.aimall.aimqb",
Expand All @@ -25,10 +25,7 @@ def test_unstored_parentgrouplabel_returns_error():

def test_g16frag_controller():
"""Test that error returns when groups are not defined"""
gr = Group(label="opt_workchain")
gr.store()
gr = Group(label="inp_frag")
gr.store()

# with pytest.raises(NotExistent) as excinfo:
con = G16FragController(
parent_group_label="inp_frag",
Expand Down

0 comments on commit 120d7b9

Please sign in to comment.