As discussed in issue #267 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No new functionality.
Making these visible should help users to find out what's going on on unexpected printer behaviour.
In verbose mode (self.p.loud = True), the code actually sending the G-code line prints this, too, so this was a duplicate.
In a source code repository, all sources should be visible, including those meant to be hidden at runtime.
As this is now part of the standard interface, it's pointless to list it as possible extension code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 5 commits left, moving the patchset from master to experimental made one commit ("repeat messages from printer only in non-verbose mode") obsolete.