Reprint after print not possible and ends in a runtime error, see Issue #1421 #1454
Conversation
DivingDuck
changed the title
There was a problem hiding this comment.
Hi @DivingDuck, I'm happy with the new test files and the code change but for the comment below. Are you willing to introduce the change now or should we wait to test it?
printrun/printcore.py
Outdated
| @@ -416,7 +416,16 @@ def startprint(self, gcode, startindex = 0): | |||
| return True | |||
|
|
|||
| self.clear = False | |||
| self._send("M110 N-1") | |||
|
|
|||
| '''Reset Gcode line number for printer, pls. see issue #1421. | |||
There was a problem hiding this comment.
This information if very useful but I would not clutter the code with it. I believe this kind of explanation belongs to the commit message that introduces the code change, not in the code itself. If you know what I mean. Plus you wouldn't need to repeat it twice. I'm happy with the change otherwise.
There was a problem hiding this comment.
No problem, I removed the comments.
|
@DivingDuck let me know if you think we should wait for the solution to be tested on Prusa's firmware. I expect it to work well but you never know. |
|
I wish I have a Prusa for testing on my hand, but I don't. |
|
@rockstorm101, Maybe we should think about a new release that incorporate all updates we did since 2.1.0? |
Yeah, absolutely, since this change fixes a regression I think we must release at least the fix. I'd say we do a minor release with all updates (i.e. go for a 2.2.0 release). What do you think? |
|
We have a plan - sounds good to me 🙂 |
For reference pls. see issue #1421
I found in my firmware test 3 different behaviors to newer Marlin versions. So we have now 3 variants:
M110 N-1for resetting the gcode line number in the printerN-1 M110N-1 M110andM110 N-1N-1 M110 + line checksumMy solution for this is adding back the old behavior and combine this with the actual implemented Prusa modification:
self._send("M110 N-1", -1, True). This ends in sendingN-1 M110 N-1*125and both, the old firmware from Marlin and for Smoothieware are happy with the gcode.Up to now there is no tester available for this solution with an actual Pusa firmware.
The pull request includes in addition 2 little gcode test files:
quicktest.gcode and quicktest.dfx for testing repeated prints
arc_test.gcode for testing the printer capability of arc movements in xyz axis
Both gcode files needs only a half minute for testing and are located in the folder testfiles. Let me know if I should delete them