Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore-invalid-uri-evidences #408

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Apr 23, 2024

PR-Codex overview

The focus of this PR is to update the Node version, handle evidence loading errors, and improve URI fetching in React components.

Detailed summary

  • Updated Node version to 16.20.2
  • Improved error handling for evidence loading
  • Enhanced URI fetching in components for better performance

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for kleros-court ready!

Name Link
🔨 Latest commit f24a31f
🔍 Latest deploy log https://app.netlify.com/sites/kleros-court/deploys/662fdcc06f36a400088bb80d
😎 Deploy Preview https://deploy-preview-408--kleros-court.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru requested review from jaybuidl and gmkung April 23, 2024 13:11
@gmkung
Copy link
Contributor

gmkung commented Apr 23, 2024

@kemuru thanks for pushing the fix.
If I read it correctly, it will now ignore non-URI values, but if an evidence entry is a non-existent URI (e.g. 404 error or other non 200 responses), the evidenceFetcher will still error out and return no evidence at all?

Copy link
Contributor

@gmkung gmkung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!
@kemuru does the error field get displayed in the UI or does the Court UI ignore it for now?

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kemuru
Copy link
Contributor Author

kemuru commented Apr 24, 2024

LGTM now! @kemuru does the error field get displayed in the UI or does the Court UI ignore it for now?

the UI should display the error card in case there is a valid URI but the network request failed to that URI, if that's your question. it does not display the URI field in that case, as a matter of fact, I could add that.

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jaybuidl jaybuidl merged commit 8a54672 into master Apr 29, 2024
7 checks passed
@jaybuidl jaybuidl deleted the fix/ignore-invalid-uri-evidences branch April 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants