-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore-invalid-uri-evidences #408
Conversation
✅ Deploy Preview for kleros-court ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kemuru thanks for pushing the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
@kemuru does the error field get displayed in the UI or does the Court UI ignore it for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the UI should display the error card in case there is a valid URI but the network request failed to that URI, if that's your question. it does not display the URI field in that case, as a matter of fact, I could add that. |
Quality Gate passedIssues Measures |
PR-Codex overview
The focus of this PR is to update the Node version, handle evidence loading errors, and improve URI fetching in React components.
Detailed summary