Make Calendar localizable #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend NativeCal example to show a localized calendar.
|
Maybe I'm missing something, but as far as I know, the calendar is already localized. If you change your iPhone's "Region Format", Kal will use the appropriate language and formatting. Why is it necessary to explicitly pass in an NSLocale object? |
|
In some multilingual regions, like Hong Kong, many users use different languages between iOS and apps. They demand in-app language change rather than system-level language change. I know that this approach opposes the iOS localization recommendations but the market really demands this feature. So it would be nice to make Kal to support passing-in NSLocale object and let the developer to choose whether adopt this approach or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make calendar localizable by initialize with NSLocale.
Amend NativeCal example to show a localized calendar.