Remove unsupported webhook fields #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used anymore, and does not with with OTP 26.
These will otherwise interfere with the tests.
jesperes
commented
Dec 5, 2023
jesperes
commented
Dec 5, 2023
mikpe
reviewed
Dec 5, 2023
| @@ -396,7 +396,7 @@ get_webhooks_pre(S) -> | |||
| get_webhooks_post(S, _Args, {ok, WebHooks0}) -> | |||
| Generated = [id, createdDate, updatedDate], | |||
| Webhooks = [lists:foldl(fun maps:remove/2, WH, Generated)|| WH <- WebHooks0], | |||
| ?assertEqual(lists:sort(Webhooks), lists:sort(maps:get(webhooks, S))), | |||
| ?assertEqual(lists:sort(maps:get(webhooks, S)), lists:sort(Webhooks)), | |||
There was a problem hiding this comment.
To make the error message make more sense, since the left is the "expected" value and the right the "actual" value.
mikpe
reviewed
Dec 5, 2023
| , <<"events">> => lists:sort(Events) | ||
| }). | ||
| Map0 = maps:remove(<<"sslVerificationRequired">>, Map), | ||
| Map1 = maps:remove(<<"scopeType">>, Map0), |
There was a problem hiding this comment.
I have a feeling this might come back and bite us in prod. And given BEC's lack of decent error messages it might be difficult to diagnose.
mikpe
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sslVerificationRequiredandscopeTypefields received from theGET .../webhooksAPI call are not supported by BEC right now. Remove them so they don't interfere with our tests.