Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error handling for coinbase in starknet_deployments.py #1650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donatik27
Copy link

Description

This PR improves error handling and logging when getting the coinbase address in starknet deployments. Added detailed error logging to help diagnose issues during deployment.

Changes

File: kakarot_scripts/deployment/starknet_deployments.py

Old code:
image

New code:
image

Why these changes are needed

  1. Better error diagnostics - Now we can see the actual error message if coinbase retrieval fails
  2. Improved debugging - Makes it easier to identify and fix issues during deployment
  3. Better logging - Provides more context about what went wrong instead of silently failing

Testing

  • Tested deployment with valid coinbase
  • Tested error handling with invalid coinbase
  • Verified error messages are properly logged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant