Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to Kiwix Server #673

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Add IPv6 support to Kiwix Server #673

merged 1 commit into from
Jun 1, 2024

Conversation

aryanA101a
Copy link
Contributor

@aryanA101a aryanA101a commented Apr 20, 2024

Fixes #545

depends on kiwix/libkiwix#1074

@kelson42 kelson42 changed the title add ipv6 support Add IPv6 support to Kiwix Server Apr 20, 2024
docs/kiwix-serve.rst Outdated Show resolved Hide resolved
src/man/kiwix-serve.1 Outdated Show resolved Hide resolved
src/server/kiwix-serve.cpp Outdated Show resolved Hide resolved
@kelson42
Copy link
Contributor

@aryanA101a Now that kiwix/libkiwix#1074 is (almost) ready, we should focus on this PR. Is this PR ready for a new review? Could you please give a specific feedback to each comment of the reviewer?

@aryanA101a aryanA101a requested a review from veloman-yunkan May 25, 2024 08:34
@kelson42
Copy link
Contributor

@aryanA101a Can we complete this PR?

@aryanA101a
Copy link
Contributor Author

I'm not sure why the build is failing. Is it due to dpkg-buildpackage does something different?
https://github.com/kiwix/kiwix-tools/actions/runs/9188369878/job/25571181092?pr=673#step:9:432
Perhaps it is not linking with libkiwix.so

@kelson42
Copy link
Contributor

@aryanA101a This is something out of the scope of this PR. I'm more concerned about the fact that other parts of the CI (like compilation on Linux) is not triggered at all!

@mgautierfr
Copy link
Member

I'm more concerned about the fact that other parts of the CI (like compilation on Linux) is not triggered at all!

Should be fixed by #679

Comment on lines 56 to 58
all : Listen for connections from all IP addresses (IPv4 and IPv6).
ipv4 : Listen for connections from all IPv4 addresses.
ipv6 : Listen for connections from all IPv6 addresses.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. from → on
  2. Make it a bulleted list (start each line with a - ). Build (via ninja doc) and check the documentation to make sure that it looks nice.

Comment on lines 33 to 37
all : Listen for connections from all IP addresses (IPv4 and IPv6).
.br
ipv4 : Listen for connections from all IPv4 addresses.
.br
ipv6 : Listen for connections from all IPv6 addresses.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from → on

@veloman-yunkan
Copy link
Collaborator

Since I actually performed the proposed changes locally (in order to find out the proper formatting of documentation) I also committed them. If you are fine with them, please rebase&fix-up and we will merge this PR.

@kelson42
Copy link
Contributor

kelson42 commented Jun 1, 2024

@aryanA101a Please squash everything in one commit

@kelson42 kelson42 merged commit 353d20b into kiwix:main Jun 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiwix-serve does not support IPv6
4 participants