Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate full-text search results into title search results #935

Merged

Conversation

Jaifroid
Copy link
Member

Fixes #930 and #931.

@Jaifroid
Copy link
Member Author

Most of the kinks are ironed out, and this appears to be working pretty well now, both in A-namespace ZIMs, and in C-namespace ZIMs (including Zimit archives, although the content of found Zimit articles is poorly formatted in Kiwix JS of course, because only the HTML is loaded with no CSS of JS).

@Jaifroid
Copy link
Member Author

Example: Full English Wikipedia with full-text search (A-namespace):

image

@Jaifroid
Copy link
Member Author

Beer Stack Exchange (OpenZim Type 1 ZIM with C-namespace):

image

@Jaifroid
Copy link
Member Author

And, for fun, Mozilla Development Network, a Zimit-style ZIM (C-namespace):

image

@Jaifroid
Copy link
Member Author

Needs thorough testing on older browsers and for null searches before merging.

@Jaifroid
Copy link
Member Author

Tests:

@Jaifroid
Copy link
Member Author

Now added better API reporting, and updated the binaries, including source code.

image

@Jaifroid
Copy link
Member Author

Tests need fixing.

@Jaifroid
Copy link
Member Author

Tests:

  • Firefox OS - degrades gracefully to title-only search
  • IE11 - same
  • Firefox Developer 109 - shows FT index results
  • Edge Chromium - same
  • Firefox Extension - shows FT index results
  • Chromium Extension - shows FT index results

@Jaifroid Jaifroid merged commit 366c0c1 into main Dec 17, 2022
@Jaifroid Jaifroid deleted the Integrate-full-text-search-results-into-title-search-results branch December 17, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch full-text Xapian search when user undertakes a title search under certain conditions
1 participant