-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate full-text search results into title search results #935
Merged
Jaifroid
merged 7 commits into
main
from
Integrate-full-text-search-results-into-title-search-results
Dec 17, 2022
Merged
Integrate full-text search results into title search results #935
Jaifroid
merged 7 commits into
main
from
Integrate-full-text-search-results-into-title-search-results
Dec 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the kinks are ironed out, and this appears to be working pretty well now, both in A-namespace ZIMs, and in C-namespace ZIMs (including Zimit archives, although the content of found Zimit articles is poorly formatted in Kiwix JS of course, because only the HTML is loaded with no CSS of JS). |
Needs thorough testing on older browsers and for null searches before merging. |
Tests:
|
Tests need fixing. |
Tests:
|
Jaifroid
deleted the
Integrate-full-text-search-results-into-title-search-results
branch
December 17, 2022 08:02
This was referenced Dec 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930 and #931.