Fix vertical positioning of popovers #674
Merged
+84
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
force-pushed
the
Fix-vertical-positioning-of-popovers
branch
from
0858b06
to
51d36e4
Compare
|
While now working well, seems to have nerfed some aspect of dark mode.... |
|
Positioning is broken when tabbing into an element. Seems we don't get proper dimensions from the offset values. Additionally, when hovering over a link inside a positioned div (e.g. navbox) the positioning goes haywire. |
Jaifroid
force-pushed
the
Fix-vertical-positioning-of-popovers
branch
from
ad0b188
to
aec69c0
Compare
|
Used a better way to detect the change with getBoundingClientRect(), but needs testing on Safari, UWP and Android. |
|
Tested on all common browsers, and also on Edge Legacy. Also Safari and iOS. As a separate issue, when a page is zoomed excessively, the popovers are rendered too large to fit on a phone screen without horizontal scrolling. But this is minor. It could be dealt with by scaling the size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #672.