Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a third intro screen to inform users about changing the storage location for downloading ZIM files. #4179

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jan 18, 2025

Fixes #3531

Day Theme

ThridScreenInDayMode.mp4

Night Theme

ThirdScreenInNightMode.mp4
  • Refactored the IntroFragmentTest to test this new intro screen.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft January 18, 2025 09:23
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review January 18, 2025 09:37
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.07%. Comparing base (c069a12) to head (8195194).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4179      +/-   ##
============================================
+ Coverage     56.91%   57.07%   +0.15%     
+ Complexity     1531     1529       -2     
============================================
  Files           313      313              
  Lines         13421    13422       +1     
  Branches       1670     1670              
============================================
+ Hits           7638     7660      +22     
+ Misses         4633     4607      -26     
- Partials       1150     1155       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 6933feb into main Jan 18, 2025
31 checks passed
@kelson42 kelson42 deleted the Fixes#3531 branch January 18, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hint to the starting introduction to select storage place (and grant universal acces rights)
3 participants