Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: ZIM files are not showing on "Library" screen when updating the app from 3.11.1 to 3.12.0. #4134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 11, 2024

Fixes #4132

Reverting the default.json, and default.json.bak files id to previous ones so that it will not affect the previous database of BookOnDiskEntity.

Before Fix

BeforeFixEdited.mp4

After Fix

Untitled.design.mp4

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft December 11, 2024 10:50
@MohitMaliFtechiz MohitMaliFtechiz changed the title Fixed: ZIM files are not showing on "Library" screen when updating the app to from 3.11.1 to 3.12.0. Fixed: ZIM files are not showing on "Library" screen when updating the app from 3.11.1 to 3.12.0. Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (9fc6e66) to head (2f27831).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4134      +/-   ##
============================================
- Coverage     58.46%   58.35%   -0.12%     
+ Complexity     1558     1553       -5     
============================================
  Files           316      316              
  Lines         13541    13541              
  Branches       1727     1727              
============================================
- Hits           7917     7902      -15     
- Misses         4485     4500      +15     
  Partials       1139     1139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review December 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last 3.12.0 destroy all libraries?!
2 participants