-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Protocol testrunner #264
base: master
Are you sure you want to change the base?
Conversation
$ node test_protocol/proto_tests.js Working: - TestRunner embeded as a transport, taking in reads/writes + events - TestRunner scripts executing against traffic + events ToDo: - Much tidying - File structure could do with being tidier - Loading TestRunner scripts from ./*.txt - Wrap TestRunner as a jest test - Include TestRunner in prod builds? Could be useful for protocol testing in live builds - Actually write some protocol test scripts
Todo:
|
I feel like |
|
||
describe('protocol test runners', async function() { | ||
it('should run all protocol test scripts', async function() { | ||
await TestProtocol() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not want to hook it into the tests a little bit better, so each test becomes it
and gets reported correctly by the test software?
bot.on('registered', function() { | ||
bot.join('#prawnsalad'); | ||
}); | ||
bot.on('join', event => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these events temporary? Should be in the txt files.
One thing that I just realized, is that we will probably want a mechanism to call methods on Something like:
Things like |
This is what hit me yesterday too. And to support something like Things like the |
Well this particular example would be solved by the ability to call methods on ircclient. If there needs to be a way to mix with js, perhaps such tests should just be written in JS entirely instead of being parsed from txt file? |
No description provided.