Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inline label design #653

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Update inline label design #653

merged 5 commits into from
Aug 15, 2023

Conversation

PavelHolec
Copy link
Collaborator

@PavelHolec PavelHolec commented Aug 15, 2023 •
edited
Loading

image

@PavelHolec PavelHolec linked an issue Aug 15, 2023 that may be closed by this pull request
Update inline label design for InputField and Select #652
Closed
@PavelHolec PavelHolec force-pushed the 652-update-inline-label-design-for-inputfield-and-select branch from 5b9af39 to c06fa60 Compare August 15, 2023 09:18
@PavelHolec PavelHolec marked this pull request as ready for review August 15, 2023 09:18
@PavelHolec PavelHolec requested a review from a team as a code owner August 15, 2023 09:18
@PavelHolec PavelHolec self-assigned this Aug 15, 2023
@PavelHolec PavelHolec added this to the 2023Q3 milestone Aug 15, 2023
@PavelHolec PavelHolec added the enhancement New feature or request label Aug 15, 2023
@PavelHolec PavelHolec force-pushed the 652-update-inline-label-design-for-inputfield-and-select branch 3 times, most recently from 841a691 to 2bddd59 Compare August 15, 2023 13:06
@PavelHolec PavelHolec force-pushed the 652-update-inline-label-design-for-inputfield-and-select branch from 69da5c5 to 16d0476 Compare August 15, 2023 14:02
@PavelHolec
Copy link
Collaborator Author

@sjavora had to update the TextField component to respect our text/font modifiers (otherwise there would be a size/baseline mismatch)

@PavelHolec PavelHolec force-pushed the 652-update-inline-label-design-for-inputfield-and-select branch from 71cd01e to bc7e2cb Compare August 15, 2023 16:20
@PavelHolec PavelHolec merged commit e7aaaf9 into main Aug 15, 2023
7 checks passed
@PavelHolec PavelHolec deleted the 652-update-inline-label-design-for-inputfield-and-select branch August 15, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjavora sjavora sjavora approved these changes

Assignees

@PavelHolec PavelHolec

Labels
enhancement New feature or request
Projects
None yet
Milestone
2023Q3
Development

Successfully merging this pull request may close these issues.

Update inline label design for InputField and Select
2 participants
@PavelHolec @sjavora